Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263665AbUFSUCW (ORCPT ); Sat, 19 Jun 2004 16:02:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264627AbUFSUCW (ORCPT ); Sat, 19 Jun 2004 16:02:22 -0400 Received: from outmx007.isp.belgacom.be ([195.238.3.234]:27321 "EHLO outmx007.isp.belgacom.be") by vger.kernel.org with ESMTP id S263665AbUFSUCT (ORCPT ); Sat, 19 Jun 2004 16:02:19 -0400 Subject: Re: [PATCH 2.6.7] ext3 s_dirt for r/w From: FabF To: Andrew Morton Cc: linux-kernel@vger.kernel.org In-Reply-To: <1087673549.2224.4.camel@localhost.localdomain> References: <1087668287.2472.4.camel@localhost.localdomain> <20040619115438.765da1c0.akpm@osdl.org> <1087673549.2224.4.camel@localhost.localdomain> Content-Type: text/plain Message-Id: <1087675448.2224.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Sat, 19 Jun 2004 22:04:08 +0200 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 22 On Sat, 2004-06-19 at 21:32, FabF wrote: > On Sat, 2004-06-19 at 20:54, Andrew Morton wrote: > > FabF wrote: > > > > > > Here is a patch setting s_dirt for read-write filesystems in ext3_init > > > (doing it in create_journal seems troublesome IMHO). > > > > Why? > ext3_create_journal is called with journal_inum parser option set which > means unjournaled r/w ext3 fs are s_dirt 0. Oops ... ^has_journal is only ext2 readable so there's no problem at that point ...Anyway, valid ext3 partition can be initialized with load_journal or create_journal so s_dirt problem remains IMHO... Regards, FabF - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/