Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264750AbUFSXAz (ORCPT ); Sat, 19 Jun 2004 19:00:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264762AbUFSXAz (ORCPT ); Sat, 19 Jun 2004 19:00:55 -0400 Received: from stress.telefonica.net ([213.4.129.135]:36746 "EHLO tnetsmtp1.mail.isp") by vger.kernel.org with ESMTP id S264750AbUFSXAv convert rfc822-to-8bit (ORCPT ); Sat, 19 Jun 2004 19:00:51 -0400 Subject: Re: pdc202xx_old serious bug with DMA on 2.6.x series From: Adolfo =?ISO-8859-1?Q?Gonz=E1lez_Bl=E1zquez?= To: Bartlomiej Zolnierkiewicz Cc: Linux Kernel In-Reply-To: <200406191846.32983.bzolnier@elka.pw.edu.pl> References: <1087253451.4817.4.camel@localhost> <20040615111552.GA12458@logos.cnet> <1087299182.3251.2.camel@localhost> <200406191846.32983.bzolnier@elka.pw.edu.pl> Content-Type: text/plain; charset=ISO-8859-15 Message-Id: <1087686048.647.9.camel@localhost> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 20 Jun 2004 01:00:48 +0200 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3440 Lines: 108 Hi, Sorry for the delay... I tried 2.5.50 and 2.5.75, and, at least for my machine, everything seems to be perfect. Then i tried every 2.6 kernel. All of them have the same buggy behaviour. These are the differences between 2.5.75 and 2.6.0 pdc202xx_old.c (sorry if this is not the correct format, im new here :) Hope this will help. Adolfo Gonz?lez ################################################################### --- linux-2.5.75/drivers/ide/pci/pdc202xx_old.c 2003-07-10 22:15:03.000000000 +0200 +++ linux-2.6.0/drivers/ide/pci/pdc202xx_old.c 2003-12-18 03:59:53.000000000 +0100 @@ -46,7 +46,6 @@ #include #include -#include "ide_modes.h" #include "pdc202xx_old.h" #define PDC202_DEBUG_CABLE 0 @@ -519,13 +518,15 @@ } else { goto fast_ata_pio; } + return hwif->ide_dma_on(drive); } else if ((id->capability & 8) || (id->field_valid & 2)) { fast_ata_pio: no_dma_set: hwif->tuneproc(drive, 5); return hwif->ide_dma_off_quietly(drive); } - return hwif->ide_dma_on(drive); + /* IORDY not supported */ + return 0; } static int pdc202xx_quirkproc (ide_drive_t *drive) @@ -749,9 +750,6 @@ hwif->tuneproc = &config_chipset_for_pio; hwif->quirkproc = &pdc202xx_quirkproc; - if (hwif->pci_dev->device == PCI_DEVICE_ID_PROMISE_20265) - hwif->addressing = (hwif->channel) ? 0 : 1; - if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) { hwif->busproc = &pdc202xx_tristate; hwif->resetproc = &pdc202xx_reset; @@ -928,7 +926,7 @@ return 0; } -static struct pci_device_id pdc202xx_pci_tbl[] __devinitdata = { +static struct pci_device_id pdc202xx_pci_tbl[] = { { PCI_VENDOR_ID_PROMISE, PCI_DEVICE_ID_PROMISE_20246, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_PROMISE, PCI_DEVICE_ID_PROMISE_20262, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, { PCI_VENDOR_ID_PROMISE, PCI_DEVICE_ID_PROMISE_20263, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2}, ################################################################### El s?b, 19-06-2004 a las 18:46, Bartlomiej Zolnierkiewicz escribi?: > Hi, > > Any news about this issue? > > On Tuesday 15 of June 2004 13:33, you wrote: > > El mar, 15-06-2004 a las 13:15, Marcelo Tosatti escribi?: > > > On Tue, Jun 15, 2004 at 01:20:03AM +0200, Adolfo Gonz?lez Bl?zquez wrote: > > > > El mar, 15-06-2004 a las 01:18, Bartlomiej Zolnierkiewicz escribi?: > > > > > On Tuesday 15 of June 2004 00:50, Adolfo Gonz?lez Bl?zquez wrote: > > > > > > Hi! > > > > > > > > > > Hi, > > > > > > > > > > > Lot of users are reporting seriour problems with pdc202xx_old ide > > > > > > pci driver. Enabling DMA on any device related with this driver > > > > > > makes the system unusable. > > > > > > > > > > > > This seems to happen in all the 2.6.x kernel series. > > > > > > > > > > Doing binary search on 2.4->2.6 kernels would help greatly > > > > > (narrowing problem to a specific kernel versions). > > > > > > > > If it helps, I tried 2.6.2, 2.6.4, 2.6.5, and 2.6.7-rc3, and all have > > > > the bug. > > > > > > And which kernels does not exhibit the problem? > > > > The 2.4 series it's ok, I'm gonna try with different 2.5.x kernels to > > see if i can discover when the bug was introduced > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/