Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264117AbUFUOYo (ORCPT ); Mon, 21 Jun 2004 10:24:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264165AbUFUOYo (ORCPT ); Mon, 21 Jun 2004 10:24:44 -0400 Received: from cantor.suse.de ([195.135.220.2]:3970 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S264117AbUFUOYk (ORCPT ); Mon, 21 Jun 2004 10:24:40 -0400 Date: Mon, 21 Jun 2004 16:24:39 +0200 Message-ID: From: Takashi Iwai To: Alan Cox Cc: perex@suse.cz, akpm@osdl.org, linux-kernel@vger.kernel.org, trivial@rustcorp.com.au Subject: Re: PATCH: Dell laptop lockup fix for ALSA In-Reply-To: <20040621121647.GA16714@devserv.devel.redhat.com> References: <20040621121647.GA16714@devserv.devel.redhat.com> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2602 Lines: 70 At Mon, 21 Jun 2004 08:16:47 -0400, Alan Cox wrote: > > OSS avoids the Dell lockup by not hitting the problem register (which > apparently breaks resume on a Sony laptop). ALSA keeps a flag and uses > pci subvendor info to clear it for problem Dell laptops. Unfortunately > there is at least one other Dell laptop which is affected. This adds > its sub id's Could you fix the comment, too? Surely it's no Sony laptop ;) -- Takashi Iwai ALSA Developer - www.alsa-project.org > > [Patch from Dan Williams @ Red Hat slightly reformatted by me] > > > --- sound/pci/nm256/nm256.c 2004-06-14 14:11:34.000000000 +0100 > +++ /tmp/nm256.c 2004-06-21 12:08:49.099484448 +0100 > @@ -1509,6 +1509,10 @@ > /* this workaround will cause lock-up after suspend/resume on Sony PCG-F305 */ > chip->latitude_workaround = 0; > } > + if (subsystem_vendor == 0x1028 && subsystem_device == 0x0080) { > + /* this workaround will cause lock-up after suspend/resume on Sony PCG-F305 */ > + chip->latitude_workaround = 0; > + } > > snd_nm256_init_chip(chip); > > > > > Developer's Certificate of Origin 1.0 > > By making a contribution to this project, I certify that: > > (a) The contribution was created in whole or in part by me and I > have the right to submit it under the open source license > indicated in the file; or > > (b) The contribution is based upon previous work that, to the best > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit that > work with modifications, whether created in whole or in part > by me, under the same open source license (unless I am > permitted to submit under a different license), as indicated > in the file; or > > (c) The contribution was provided directly to me by some other > person who certified (a), (b) or (c) and I have not modified > it. > > > Signed-off-by: Alan Cox > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/