Date: Mon, 21 Jun 2004 10:33:01 -0400 (EDT)
From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: Urban Widmark <urban@teststation.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH][2.6] Fix smbfs readdir oops
In-Reply-To: <Pine.LNX.4.44.0406211055340.19689-100000@cola.local>
Message-ID: <Pine.LNX.4.58.0406211030340.3273@montezuma.fsmlabs.com>
References: <Pine.LNX.4.44.0406211055340.19689-100000@cola.local>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1406
Lines: 36

On Mon, 21 Jun 2004, Urban Widmark wrote:

> On Sun, 20 Jun 2004, Zwane Mwaikambo wrote:
>
> > This has been reported a couple of times and is consistently causing some
> > folks grief, so Urban, would you mind terribly if i send this patch to at
> > least clear current bug reports. If there is additional stuff you want
> > ontop of this let me know and i can send a follow up patch.
>
> I should read all my mail before replying. Yes, this is a problem for
> people and I was thinking the same thing that we should get this in now
> and fix the remaining problem later.
>
> One question:
> Why do you need conn_complete? Isn't "server->state == CONN_VALID" good
> enough?

I couldn't use CONN_VALID to mark when the connection was completely up
because it's used in some branch decisions during connection setup. So
moving it further down in smb_newconn broke things for the testers.

> And are you still working on fixing the remaining "multiple-ls" problem?
> (The one where one ls would work and the other return an error).
> Or is that fixed in this version?

I'll be working on that, i recall that there is also a bugzilla entry for
it.

Thanks,
	Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/