Date: Mon, 21 Jun 2004 11:46:05 -0700
From: Andrew Morton <akpm@osdl.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: da-x@colinux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing NULL check in drivers/char/n_tty.c
Message-Id: <20040621114605.4df2c05e.akpm@osdl.org>
In-Reply-To: <40D6F986.3010904@microgate.com>
References: <20040621063845.GA6379@callisto.yi.org>
	<20040620235824.5407bc4c.akpm@osdl.org>
	<20040621073644.GA10781@callisto.yi.org>
	<20040621003944.48f4b4be.akpm@osdl.org>
	<20040621082430.GA11566@callisto.yi.org>
	<40D6F986.3010904@microgate.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 26

Paul Fulghum <paulkf@microgate.com> wrote:
>
> 13 other drivers call ldisc.chars_in_buffer without checking
>  for ldisc.chars_in_buffer == NULL, but only inside conditional
>  compilation for debug output. The value is not used, only logged.
>  These conditional debug items look like cut and paste from
>  one serial driver to another, and I doubt
>  they have been recently used (or used at all).
> 
>  Which would be better?
>  1. Ignore this
>  2. Fix conditional debug output to check
>      for ldisc.chars_in_buffer==NULL
>  3. Remove conditional debug output

Option 1 is quite valid.  There are no bugs here, yes?

If someone for some reason wants to clean all this up, the best way would
be to require that ->chars_in_buffer always be valid, hence remove all
those checks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/