Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261682AbUFVJLT (ORCPT ); Tue, 22 Jun 2004 05:11:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261704AbUFVJLT (ORCPT ); Tue, 22 Jun 2004 05:11:19 -0400 Received: from tao.natur.cuni.cz ([195.113.56.1]:531 "EHLO tao.natur.cuni.cz") by vger.kernel.org with ESMTP id S261682AbUFVJLQ (ORCPT ); Tue, 22 Jun 2004 05:11:16 -0400 X-Obalka-From: mmokrejs@natur.cuni.cz Date: Tue, 22 Jun 2004 11:10:55 +0200 (CEST) From: =?iso-8859-2?Q?Martin_MOKREJ=A9?= To: Mikael Pettersson cc: Linux Kernel Mailing Subject: Re: Cannot compile linux-2.4.27-rc1 ... ipt_REJECT.c In-Reply-To: <16599.20905.527283.517210@alkaid.it.uu.se> Message-ID: References: <16598.56442.254480.281844@alkaid.it.uu.se> <16599.20905.527283.517210@alkaid.it.uu.se> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2995 Lines: 64 On Mon, 21 Jun 2004, Mikael Pettersson wrote: Thanks, this patch helped. > Martin MOKREJ? writes: > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-rc1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -fno-unit-at-a-time -nostdinc -iwithprefix include -DKBUILD_BASENAME=vt -c -o vt.o vt.c > > vt.c: In function `do_kdsk_ioctl': > > vt.c:166: warning: comparison is always false due to limited range of data type > > vt.c: In function `do_kdgkb_ioctl': > > vt.c:283: warning: comparison is always false due to limited range of data type > > This happens with many gcc-3.x versions, not just gcc-3.4. > In any case, it doesn't prevent a successful kernel build. > > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-rc1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -fno-unit-at-a-time -nostdinc -iwithprefix include -DKBUILD_BASENAME=highmem -c -o highmem.o highmem.c > > highmem.c:133: error: conflicting types for 'kmap_high' > > /usr/src/linux-2.4.27-rc1/include/asm/highmem.h:59: error: previous declaration of 'kmap_high' was here > > highmem.c:133: error: conflicting types for 'kmap_high' > > /usr/src/linux-2.4.27-rc1/include/asm/highmem.h:59: error: previous declaration of 'kmap_high' was here > > highmem.c:158: error: conflicting types for 'kunmap_high' > > /usr/src/linux-2.4.27-rc1/include/asm/highmem.h:60: error: previous declaration of 'kunmap_high' was here > > highmem.c:158: error: conflicting types for 'kunmap_high' > > /usr/src/linux-2.4.27-rc1/include/asm/highmem.h:60: error: previous declaration of 'kunmap_high' was here > > This is HIGHMEM which I never tested before. The problem is yet > another FASTCALL/fastcall discrepancy where a function's definition > doesn't have the exact same attributes as its prototype. > > My updated gcc340 patch fixes this problem. Get > > or simply apply the patch below on top of the previous version. > > /Mikael > > --- linux-2.4.27-rc1/mm/highmem.c.~1~ 2003-06-14 13:30:29.000000000 +0200 > +++ linux-2.4.27-rc1/mm/highmem.c 2004-06-21 22:42:58.000000000 +0200 > @@ -129,7 +129,7 @@ > return vaddr; > } > > -void *kmap_high(struct page *page, int nonblocking) > +void fastcall *kmap_high(struct page *page, int nonblocking) > { > unsigned long vaddr; > > @@ -154,7 +154,7 @@ > return (void*) vaddr; > } > > -void kunmap_high(struct page *page) > +void fastcall kunmap_high(struct page *page) > { > unsigned long vaddr; > unsigned long nr; > -- Martin Mokrejs GPG key is at http://www.natur.cuni.cz/~mmokrejs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/