Date: Tue, 22 Jun 2004 21:01:43 +0900
From: Takao Indoh <indou.takao@soft.fujitsu.com>
Subject: Re: [PATCH 2/4]Diskdump Update
In-reply-to: <20040617133906.GA32219@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Message-id: <E3C45850AF4E78indou.takao@soft.fujitsu.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
References: <20040617133906.GA32219@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 39

On Thu, 17 Jun 2004 14:39:06 +0100, Christoph Hellwig wrote:

>> >please make it not a module of it's own but part of the
>> >scsi code, 
>> 
>> Do you mean scsi_dump module should be merged with sd_mod.o or scsi_mod.o?
>
>scsi_mod.o.

It is difficult because disk_dump and scsi_dump try to check checksum of
itself using check_crc_module so as to confirm whether module is
compromised or not.

drivers/scsi/scsi_dump.c:
static int
scsi_dump_sanity_check(struct disk_dump_device *dump_device)
{
        struct scsi_device *sdev = dump_device->device;
        struct Scsi_Host *host = sdev->host;
        int adapter_sanity = 0;
        int sanity = 0;

        if (!check_crc_module()) {
                Err("checksum error. scsi dump module may be compromised.
");
                return -EINVAL;
        }

Therefore, scsi_dump need to be always compiled as independent module.
If scsi_dump is merged with scsi_mod, scsi_mod is not able to be
compiled statically.

Best Regards,
Takao Indoh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/