Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263003AbUFVMMG (ORCPT ); Tue, 22 Jun 2004 08:12:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263019AbUFVMMG (ORCPT ); Tue, 22 Jun 2004 08:12:06 -0400 Received: from [213.146.154.40] ([213.146.154.40]:36996 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S263003AbUFVMMC (ORCPT ); Tue, 22 Jun 2004 08:12:02 -0400 Date: Tue, 22 Jun 2004 13:12:01 +0100 From: Christoph Hellwig To: Takao Indoh Cc: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4]Diskdump Update Message-ID: <20040622121201.GA1820@infradead.org> Mail-Followup-To: Christoph Hellwig , Takao Indoh , linux-kernel@vger.kernel.org References: <20040617133906.GA32219@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 25 On Tue, Jun 22, 2004 at 09:01:43PM +0900, Takao Indoh wrote: > On Thu, 17 Jun 2004 14:39:06 +0100, Christoph Hellwig wrote: > > >> >please make it not a module of it's own but part of the > >> >scsi code, > >> > >> Do you mean scsi_dump module should be merged with sd_mod.o or scsi_mod.o? > > > >scsi_mod.o. > > It is difficult because disk_dump and scsi_dump try to check checksum of > itself using check_crc_module so as to confirm whether module is > compromised or not. > Therefore, scsi_dump need to be always compiled as independent module. > If scsi_dump is merged with scsi_mod, scsi_mod is not able to be > compiled statically. So check if it's a module and otherwise not. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/