Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262101AbUFVNo3 (ORCPT ); Tue, 22 Jun 2004 09:44:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263663AbUFVNo3 (ORCPT ); Tue, 22 Jun 2004 09:44:29 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:8415 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S262101AbUFVNo1 (ORCPT ); Tue, 22 Jun 2004 09:44:27 -0400 Message-ID: <40D837AB.2000104@pobox.com> Date: Tue, 22 Jun 2004 09:44:11 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andi Kleen CC: Carl-Daniel Hailfinger , linux-kernel@vger.kernel.org Subject: Re: [PATCH] new device support for forcedeth.c fourth try References: <29ACK-1wm-17@gated-at.bofh.it> <29B5I-1QM-3@gated-at.bofh.it> <29QeD-5kp-11@gated-at.bofh.it> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 25 Andi Kleen wrote: > Carl-Daniel Hailfinger writes: > > >>Known Bug: You will get a "bad: scheduling while atomic" message because >>of the msleep(500) in PHY reset. >> >>Any suggestions how I can avoid this message? Using mdelay(500) has its >>share of problems too, because it will cause lost time. > > > Use schedule_work() to push it into a worker thread. Agreed. This is what I am moving net drivers to, for slow path stuff like chip reset or twiddling the phy. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/