To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andi Kleen <ak@muc.de>,
       Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new device support for forcedeth.c fourth try
References: <29ACK-1wm-17@gated-at.bofh.it> <29B5I-1QM-3@gated-at.bofh.it>
	<29QeD-5kp-11@gated-at.bofh.it>
	<m3llifevr8.fsf@averell.firstfloor.org> <40D837AB.2000104@pobox.com>
From: Roland Dreier <roland@topspin.com>
Date: Tue, 22 Jun 2004 06:54:48 -0700
In-Reply-To: <40D837AB.2000104@pobox.com> (Jeff Garzik's message of "Tue, 22
 Jun 2004 09:44:11 -0400")
Message-ID: <52d63rpujb.fsf@topspin.com>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through
 Obscurity, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 977
Lines: 27

>>>>> "Jeff" == Jeff Garzik <jgarzik@pobox.com> writes:

    > Andi Kleen wrote:
    >> Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>
    >> writes:

    >>> Known Bug: You will get a "bad: scheduling while atomic"
    >>> message because of the msleep(500) in PHY reset.

    >>> Any suggestions how I can avoid this message? Using
    >>> mdelay(500) has its share of problems too, because it will
    >>> cause lost time.

    >> Use schedule_work() to push it into a worker thread.

    > Agreed.  This is what I am moving net drivers to, for slow
    > path stuff like chip reset or twiddling the phy.

In this case is it possible to use schedule_delayed_work() to avoid
stalling keventd for half a second?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/