Message-ID: <40D84308.6010803@pobox.com>
Date: Tue, 22 Jun 2004 10:32:40 -0400
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
MIME-Version: 1.0
To: Roland Dreier <roland@topspin.com>
CC: Andi Kleen <ak@muc.de>,
       Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new device support for forcedeth.c fourth try
References: <29ACK-1wm-17@gated-at.bofh.it> <29B5I-1QM-3@gated-at.bofh.it>	<29QeD-5kp-11@gated-at.bofh.it>	<m3llifevr8.fsf@averell.firstfloor.org> <40D837AB.2000104@pobox.com> <52d63rpujb.fsf@topspin.com>
In-Reply-To: <52d63rpujb.fsf@topspin.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1209
Lines: 36

Roland Dreier wrote:
>>>>>>"Jeff" == Jeff Garzik <jgarzik@pobox.com> writes:
> 
> 
>     > Andi Kleen wrote:
>     >> Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>
>     >> writes:
> 
>     >>> Known Bug: You will get a "bad: scheduling while atomic"
>     >>> message because of the msleep(500) in PHY reset.
> 
>     >>> Any suggestions how I can avoid this message? Using
>     >>> mdelay(500) has its share of problems too, because it will
>     >>> cause lost time.
> 
>     >> Use schedule_work() to push it into a worker thread.
> 
>     > Agreed.  This is what I am moving net drivers to, for slow
>     > path stuff like chip reset or twiddling the phy.
> 
> In this case is it possible to use schedule_delayed_work() to avoid
> stalling keventd for half a second?

Certainly.  Won't work in a 2.4.x backport, though.

This reminds me, I'm tempted to create a "you can sleep for a while in 
it" workqueue, to avoid tying up keventd.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/