Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265923AbUFVVPs (ORCPT ); Tue, 22 Jun 2004 17:15:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265898AbUFVVMU (ORCPT ); Tue, 22 Jun 2004 17:12:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:21464 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S265655AbUFVUsD (ORCPT ); Tue, 22 Jun 2004 16:48:03 -0400 Date: Tue, 22 Jun 2004 13:47:38 -0700 From: "David S. Miller" To: William Lee Irwin III Cc: linux-kernel@vger.kernel.org, rddunlap@osdl.org Subject: Re: [profile]: [21/23] use atomic_t for prof_buffer Message-Id: <20040622134738.3f9d8d76.davem@redhat.com> In-Reply-To: <20040622201654.GG2135@holomorphy.com> References: <0406220817.4aXa3aHb5aMb4a3a1aYaZa3aIbXa5aIbKbJbXa1aLbJb4a2a2aZaYa0aHb2aMbYa15250@holomorphy.com> <0406220817.2aWaKb4aHb4aMbZaWaLbKb5aLbXaXa0aWaYa2a1aKb5aMb5aXaZa3aIbIbIbHbYa15250@holomorphy.com> <20040622130116.6e12a15a.davem@redhat.com> <20040622201654.GG2135@holomorphy.com> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 22 On Tue, 22 Jun 2004 13:16:54 -0700 William Lee Irwin III wrote: > On Tue, 22 Jun 2004 08:17:55 -0700 William Lee Irwin III wrote: > >> Convert prof_buffer to an array of atomic_t's. > > On Tue, Jun 22, 2004 at 01:01:16PM -0700, David S. Miller wrote: > > Part of a data type exported to userspace, is it not? > > Thus, is it really valid to change it like this? > > They're copied raw to userspace now and casted to atomic_t for all > modifications except for sparc32, arm, h8300, m68k, and m68knommu, > where it's still equivalent (the atomic operations just do normal > arithmetic under hashed locks or with ll/sc or other easily zennable > asm), so there is no change. Or did I miss an arch? That sets my mind at ease, looks good. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/