Subject: Re: [PATCH] ppc32: Support for new Apple laptop models
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>
In-Reply-To: <200406221745.31553.jbarnes@engr.sgi.com>
References: <1087934829.1832.3.camel@gaston>
	 <200406221745.31553.jbarnes@engr.sgi.com>
Content-Type: text/plain
Message-Id: <1087940927.1854.43.camel@gaston>
Mime-Version: 1.0
Date: Tue, 22 Jun 2004 16:48:48 -0500
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1290
Lines: 30

On Tue, 2004-06-22 at 16:45, Jesse Barnes wrote:
> On Tuesday, June 22, 2004 4:07 pm, Benjamin Herrenschmidt wrote:
> > This patch adds support for newer Apple laptop models. It adds the basic
> > identification for the new motherboards and the cpufreq support for models
> > using the new 7447A CPU from Motorola.
> 
> And here's a patch to add sound support for some of the newer PowerBooks.  It 
> appears that this chip supports the AWACS sample rates, but has a 
> snapper-style mixer.  Tested and works on my PowerBook5,4.
> 
> Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Can you check out in more details the OS X driver ? I think there
need to be some i2s tweaking when changing the format and/or the
frequency. Doing that right would allow to support 8 & 16 bits
properly at least. 

Also, don't leave the commented out line, especially with  the c++
style comments. If the chip can byteswap, make sure you have proper
code to do this, if not, leave can_byteswap to 0, or people will
experience all sorts of funny troubles ;)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/