To: long <tlnguyen@snoqualmie.dp.intel.com>
Cc: ak@muc.de, akpm@osdl.org, greg@kroah.com, jgarzik@pobox.com,
       linux-kernel@vger.kernel.org, tom.l.nguyen@intel.com,
       zwane@linuxpower.ca, eli@mellanox.co.il
Subject: Re: [PATCH]2.6.7 MSI-X Update
References: <200406222148.i5MLmA4Y001949@snoqualmie.dp.intel.com>
From: Roland Dreier <roland@topspin.com>
Date: Tue, 22 Jun 2004 16:57:05 -0700
In-Reply-To: <200406222148.i5MLmA4Y001949@snoqualmie.dp.intel.com> (long's
 message of "Tue, 22 Jun 2004 14:48:10 -0700")
Message-ID: <52n02vkuy6.fsf@topspin.com>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through
 Obscurity, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 733
Lines: 21

This looks good, a definite improvement over what's currently in the
kernel.  I do have one question about the whole msi.c file (and this
applies to the code that's already in the tree, too).  Why is config
space being accessed via calls like

	dev->bus->ops->read(dev->bus, dev->devfn, ... )

instead of just calling

        pci_read_config_word(dev, ... )

The only difference seems to be that MSI is bypassing the locking in
access.c.  Is there some reason for this?

Thanks,
  Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/