Message-ID: <40D8CE3F.4010306@pobox.com>
Date: Tue, 22 Jun 2004 20:26:39 -0400
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
MIME-Version: 1.0
To: Roland Dreier <roland@topspin.com>
CC: long <tlnguyen@snoqualmie.dp.intel.com>, akpm@osdl.org, greg@kroah.com,
       linux-kernel@vger.kernel.org, tom.l.nguyen@intel.com
Subject: Re: [PATCH]2.6.7 MSI-X Update
References: <200406222148.i5MLmA4Y001949@snoqualmie.dp.intel.com> <52n02vkuy6.fsf@topspin.com>
In-Reply-To: <52n02vkuy6.fsf@topspin.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 890
Lines: 28

Roland Dreier wrote:
> This looks good, a definite improvement over what's currently in the
> kernel.  I do have one question about the whole msi.c file (and this
> applies to the code that's already in the tree, too).  Why is config
> space being accessed via calls like
> 
> 	dev->bus->ops->read(dev->bus, dev->devfn, ... )
> 
> instead of just calling
> 
>         pci_read_config_word(dev, ... )
> 
> The only difference seems to be that MSI is bypassing the locking in
> access.c.  Is there some reason for this?

hmmmmmmm.

Unless it's already inside the lock somehow...  it definitely needs to 
take the lock, one way or another.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/