Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [PATCH]2.6.7 MSI-X Update
Date: Wed, 23 Jun 2004 09:58:50 -0700
Message-ID: <C7AB9DA4D0B1F344BF2489FA165E5024057E5AB3@orsmsx404.amr.corp.intel.com>
Thread-Topic: [PATCH]2.6.7 MSI-X Update
Thread-Index: AcRYwmf4u2lU6ZiXSh23inY3QDd0twAf/Kgg
From: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
To: "Roland Dreier" <roland@topspin.com>
Cc: <ak@muc.de>, <akpm@osdl.org>, <greg@kroah.com>, <jgarzik@pobox.com>,
       <linux-kernel@vger.kernel.org>, <zwane@linuxpower.ca>,
       <eli@mellanox.co.il>, "Nguyen, Tom L" <tom.l.nguyen@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 27

On Tuesday, June 22, 2004 Roland Dreier wrote: 
>This looks good, a definite improvement over what's currently in the
>kernel.  I do have one question about the whole msi.c file (and this
>applies to the code that's already in the tree, too).  Why is config
>space being accessed via calls like
>
>	dev->bus->ops->read(dev->bus, dev->devfn, ... )
>
>instead of just calling
>
>        pci_read_config_word(dev, ... )
>
>The only difference seems to be that MSI is bypassing the locking in
>access.c.  Is there some reason for this?

I think that the locking in access.c is not necessary. But I agree 
with you that using pci_read_config_word() would be cleaner. 

Thanks,
Long


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/