Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266666AbUFWVEN (ORCPT ); Wed, 23 Jun 2004 17:04:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266674AbUFWVEM (ORCPT ); Wed, 23 Jun 2004 17:04:12 -0400 Received: from fw.osdl.org ([65.172.181.6]:11674 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266666AbUFWVED (ORCPT ); Wed, 23 Jun 2004 17:04:03 -0400 Date: Wed, 23 Jun 2004 14:06:50 -0700 From: Andrew Morton To: FabF Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.7-mm1] MBR centralization Message-Id: <20040623140650.46f184bd.akpm@osdl.org> In-Reply-To: <1088025348.2213.32.camel@localhost.localdomain> References: <1088025348.2213.32.camel@localhost.localdomain> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 20 FabF wrote: > > +/*Master boot record magic numbers*/ > +#define MSDOS_MBR_SIGNATURE 0xaa55 > +#define MSDOS_MBR(p) le16_to_cpu((u16)*p) == MSDOS_MBR_SIGNATURE I'd make this /* * Check for MSDOS Master Boot Record signature */ static inline int msdos_mbr(u16 v) { return le16_to_cpu(v) == 0xaa55; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/