Date: Wed, 23 Jun 2004 22:24:59 +0100
From: viro@parcelfarce.linux.theplanet.co.uk
To: mikem@beardog.cca.cpqcorp.net
Cc: linux-kernel@vger.kernel.org, viro@www.linux.org.uk, bob.montgomery@hp.com
Subject: Re: problems with alloc_disk in genhd.c
Message-ID: <20040623212459.GK12308@parcelfarce.linux.theplanet.co.uk>
References: <20040623211829.GC16336@beardog.cca.cpqcorp.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040623211829.GC16336@beardog.cca.cpqcorp.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 20

On Wed, Jun 23, 2004 at 04:18:29PM -0500, mikem@beardog.cca.cpqcorp.net wrote:
> In the  ioctl we are doing
> 
>         /* count partitions 1 to 15 with sizes > 0 */
>         for(i=0; i <MAX_PART; i++) {

... followed by what?

Array of per-partition structures contains the data for partitions,
obviously.  And drivers have no damn business to ever touching it
directly, while we are at it.

BTW, take a look at the comment and loop following it.  And note
that you are doing 16 iterations in the loop, contrary to what
the comment above it says.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/