Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263059AbUFXEjy (ORCPT ); Thu, 24 Jun 2004 00:39:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263804AbUFXEjy (ORCPT ); Thu, 24 Jun 2004 00:39:54 -0400 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:64130 "EHLO dsl.commfireservices.com") by vger.kernel.org with ESMTP id S263059AbUFXEjx (ORCPT ); Thu, 24 Jun 2004 00:39:53 -0400 Date: Thu, 24 Jun 2004 00:42:04 -0400 (EDT) From: Zwane Mwaikambo To: Rusty Russell Cc: Linux Kernel , Andrew Morton , Manfred Spraul Subject: Re: [PATCH][2.6] Fix module_text_address/store_stackinfo race In-Reply-To: <1088051071.21510.8.camel@bach> Message-ID: References: <1088051071.21510.8.camel@bach> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 20 On Thu, 24 Jun 2004, Rusty Russell wrote: > On Wed, 2004-06-23 at 18:02, Zwane Mwaikambo wrote: > > store_stackinfo() does an unlocked module list walk during normal runtime > > which opens up a race with the module load/unload code. This can be > > triggered by simply unloading and loading a module in a loop with > > CONFIG_DEBUG_PAGEALLOC resulting in store_stackinfo() tripping over bad > > list pointers. > > Hmmm... > > You can't move kernel_text_address into module.c, since it isn't > compiled for CONFIG_MODULES=n. Good point, how about if i make modlist_lock a global? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/