To: Andreas Dilger <adilger@clusterfs.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: Testing for kernel features in external modules
References: <20040624203043.GA4557@mars.ravnborg.org>
	<20040624203516.GV31203@schnapps.adilger.int>
From: Gerd Knorr <kraxel@bytesex.org>
Organization: SUSE Labs, Berlin
Date: 24 Jun 2004 23:07:45 +0200
In-Reply-To: <20040624203516.GV31203@schnapps.adilger.int>
Message-ID: <87d63ois0u.fsf@bytesex.org>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 18

Andreas Dilger <adilger@clusterfs.com> writes:

> Ideally, when people make an incompatible kernel API change like this
> they would just #define HAVE_REMAP_PAGE_RANGE_VMA in the header that
> declares remap_page_range() directly (e.g. KERNEL_AS_O_DIRECT was added
> for this reason) instead of external builds having to figure this out
> themselves.  Adding the check script is no less work than just adding
> the #define to the appropriate header directly.

I fully agree here, just having #defines for kernel features (which
can't be detected otherwise) is much easier.

  Ge- "#define HAVE_V4L2 1" rd

-- 
2004-06-24: Switched mail/news setup to a new machine.  If something
is unusual/strange/broken/whatever feel free to drop me a note.
	=> kraxel@bytesex.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/