Date: Thu, 24 Jun 2004 16:33:58 -0700
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Adrian Bunk <bunk@fs.tum.de>
cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] add required dependencies to X86_NUMAQ
Message-ID: <3450000.1088120038@flay>
In-Reply-To: <20040624231033.GF26669@fs.tum.de>
References: <20040624231033.GF26669@fs.tum.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1222
Lines: 37

> If you select another option, you have to ensure that the dependencies 
> of the selected options are met.
> 
> The following patch adds to X86_NUMAQ the required dependencies for the 
> selected NUMA:
> 
> --- linux-2.6.7-mm2-full/arch/i386/Kconfig.old	2004-06-24 22:42:32.000000000 +0200
> +++ linux-2.6.7-mm2-full/arch/i386/Kconfig	2004-06-24 22:44:53.000000000 +0200
> @@ -65,6 +65,7 @@
>  
>  config X86_NUMAQ
>  	bool "NUMAQ (IBM/Sequent)"
> +	depends on SMP && HIGHMEM64G
>  	select DISCONTIGMEM
>  	select NUMA
>  	help

Mmmm. As we already have this:

config NUMA
        bool "Numa Memory Allocation and Scheduler Support"
        depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SU
MMIT && ACPI))
        default n if X86_PC
        default y if (X86_NUMAQ || X86_SUMMIT)

do we really need to cascade it back out like that into everything that
selects NUMA? Perhaps we should make NUMA select SMP && HIGHMEM64G, rather
than depend on it?

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/