From: Andreas Gruenbacher <agruen@suse.de>
Organization: SUSE Labs
To: Andreas Dilger <adilger@clusterfs.com>
Subject: Re: RFC: Testing for kernel features in external modules
Date: Fri, 25 Jun 2004 10:32:22 +0200
User-Agent: KMail/1.6.2
Cc: linux-kernel@vger.kernel.org
References: <20040624203043.GA4557@mars.ravnborg.org> <20040624203516.GV31203@schnapps.adilger.int>
In-Reply-To: <20040624203516.GV31203@schnapps.adilger.int>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <200406251032.22797.agruen@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 21

On Thursday 24 June 2004 22:35, Andreas Dilger wrote:
> Ideally, when people make an incompatible kernel API change like this
> they would just #define HAVE_REMAP_PAGE_RANGE_VMA in the header that
> declares remap_page_range() directly (e.g. KERNEL_AS_O_DIRECT was added
> for this reason) instead of external builds having to figure this out
> themselves.  Adding the check script is no less work than just adding
> the #define to the appropriate header directly.

I disagree. I don't think we want to clutter the code with feature definitions 
that have no known users. That doesn't age/scale very well. It's easy enough 
to test for features in the external module.

Cheers,
-- 
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX AG
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/