Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263574AbUF0PpW (ORCPT ); Sun, 27 Jun 2004 11:45:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263656AbUF0PpW (ORCPT ); Sun, 27 Jun 2004 11:45:22 -0400 Received: from kweetal.tue.nl ([131.155.3.6]:20238 "EHLO kweetal.tue.nl") by vger.kernel.org with ESMTP id S263574AbUF0PpT (ORCPT ); Sun, 27 Jun 2004 11:45:19 -0400 Date: Sun, 27 Jun 2004 17:45:15 +0200 From: Andries Brouwer To: Alan Stern Cc: Oliver Neukum , Andries Brouwer , Pete Zaitcev , greg@kroah.com, arjanv@redhat.com, jgarzik@redhat.com, tburke@redhat.com, linux-kernel@vger.kernel.org, mdharm-usb@one-eyed-alien.net, david-b@pacbell.net Subject: Re: drivers/block/ub.c Message-ID: <20040627154515.GI5526@pclin040.win.tue.nl> References: <200406271624.18984.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Spam-DCC: : kweetal.tue.nl 1074; Body=1 Fuz1=1 Fuz2=1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 495 Lines: 17 On Sun, Jun 27, 2004 at 11:19:38AM -0400, Alan Stern wrote: > My favorite approach has always been: > > put_be32(cmd->cdb + 2, block); Yes, not bad. I still prefer writing explicitly what happens. But this is a fairly clean alternative. Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/