Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265144AbUF1WkW (ORCPT ); Mon, 28 Jun 2004 18:40:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265267AbUF1WkW (ORCPT ); Mon, 28 Jun 2004 18:40:22 -0400 Received: from stat1.steeleye.com ([65.114.3.130]:13028 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S265144AbUF1WkS (ORCPT ); Mon, 28 Jun 2004 18:40:18 -0400 Subject: Re: PATCH] dma_get_required_mask() From: James Bottomley To: "David S. Miller" Cc: Andrew Morton , Linus Torvalds , SCSI Mailing List , Linux Kernel In-Reply-To: <20040628152839.23178136.davem@redhat.com> References: <1088457050.2004.40.camel@mulgrave> <20040628152839.23178136.davem@redhat.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-9) Date: 28 Jun 2004 17:40:06 -0500 Message-Id: <1088462407.2003.54.camel@mulgrave> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 18 On Mon, 2004-06-28 at 17:28, David S. Miller wrote: > Maybe you should tweak the default implementation such that > something reasonable happens on 64-bit platforms that > define dma_addr_t as a 32-bit quantity. :-) Actually, the default implementation should work on these platforms too. Since it's impossible to set a mask over 32 bits, then the best dma_get_required_mask() will do is return a full spread of 32 bits, since the memory mask is anded with the current dma mask. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/