To: "David S. Miller" <davem@redhat.com>
Cc: Scott Wood <scott@timesys.com>, oliver@neukum.org, zaitcev@redhat.com,
       greg@kroah.com, arjanv@redhat.com, jgarzik@redhat.com,
       tburke@redhat.com, linux-kernel@vger.kernel.org,
       stern@rowland.harvard.edu, mdharm-usb@one-eyed-alien.net,
       david-b@pacbell.net
Subject: Re: drivers/block/ub.c
References: <20040626130645.55be13ce@lembas.zaitcev.lan>
	<20040628141517.GA4311@yoda.timesys>
	<20040628132531.036281b0.davem@redhat.com>
	<200406282257.11026.oliver@neukum.org>
	<20040628140343.572a0944.davem@redhat.com>
	<20040628211857.GA5508@yoda.timesys>
	<20040628152208.20fe97f1.davem@redhat.com>
From: Roland Dreier <roland@topspin.com>
Date: Mon, 28 Jun 2004 15:40:45 -0700
In-Reply-To: <20040628152208.20fe97f1.davem@redhat.com> (David S. Miller's
 message of "Mon, 28 Jun 2004 15:22:08 -0700")
Message-ID: <52oen3tifm.fsf@topspin.com>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through
 Obscurity, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 35

    David> Try it out if you don't believe someone who has maintained
    David> the Linux networking for 7 years and sits on the GCC
    David> Steering Committee.  :-)

Just so I'm sure I'm not misunderstanding, are you promising me that I
will never get bitten on the ass on any architecture with kernel code
that assumes the compiler will never add padding as long as struct
fields are naturally aligned to their size? :-)

For example, you're saying I'm definitely safe declaring a structure
(used as a HW descriptor) like say

	struct mthca_qp_path {
		u32 port_pkey;
		u8  rnr_retry;
		u8  g_mylmc;
		u16 rlid;
		u8  ackto;
		u8  mgid_index;
		u8  static_rate;
		u8  hop_limit;
		u32 sl_tclass_flowlabel;
		u8  rgid[16];
	};

without __attribute__((packed))?  (Of course I'll only use this struct
aligned to its size)

Thanks,
  Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/