Date: Mon, 28 Jun 2004 15:39:41 -0700
From: "David S. Miller" <davem@redhat.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-scsi@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: PATCH] dma_get_required_mask()
Message-Id: <20040628153941.1317d9bf.davem@redhat.com>
In-Reply-To: <1088462407.2003.54.camel@mulgrave>
References: <1088457050.2004.40.camel@mulgrave>
	<20040628152839.23178136.davem@redhat.com>
	<1088462407.2003.54.camel@mulgrave>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 860
Lines: 19

On 28 Jun 2004 17:40:06 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> On Mon, 2004-06-28 at 17:28, David S. Miller wrote:
> > Maybe you should tweak the default implementation such that
> > something reasonable happens on 64-bit platforms that
> > define dma_addr_t as a 32-bit quantity. :-)
> 
> Actually, the default implementation should work on these platforms
> too.  Since it's impossible to set a mask over 32 bits, then the best
> dma_get_required_mask() will do is return a full spread of 32 bits,
> since the memory mask is anded with the current dma mask.

Perfect, I didn't notice that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/