Message-ID: <40E2783D.5040108@greatcn.org>
Date: Wed, 30 Jun 2004 16:22:21 +0800
From: Coywolf Qi Hunt <coywolf@greatcn.org>
User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626)
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
CC: akpm@osdl.org
References: <40E162EF.7010607@greatcn.org>
In-Reply-To: <40E162EF.7010607@greatcn.org>
Subject: [PATCH] share all PFN_* 
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 40

Coywolf Qi Hunt wrote:

> Hello all,
>
> There's too many macros definitions PFN_UP PFN_DOWN PFN_PHYS PFN_ALIGN 
> scattered all over.
> How about a patch move them all into one header file(kernel.h or init.h)
> and share only one copy of them like what min and max. I'd like to 
> make it.
>
>
>       coywolf
>
This patch splits out asm-generic/page.h and includes it at the bottom
of all arch specific page.h's.

This approach is more easy and *safe* than move the macros into kernel.h
or other, and also prepares for future. By nested into page.h, we can make
sure it's no problem to simply remove those definitions without adding new
include statements.

Here is it. http://greatcn.org/~coywolf/patches/2.6/share-PFN.patch


btw, these are all identical replacements, except on arm26(Matt Heler 
told me).
Arm26 implementation has done too much on this point.

On arm26:  #define PFN_UP(x) (PAGE_ALIGN(x) >> PAGE_SHIFT)
PAGE_ALIGN is no use here since >> followed

-- 
Coywolf Qi Hunt
Admin of http://GreatCN.org and http://LoveCN.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/