MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16610.42236.698377.733729@cargo.ozlabs.ibm.com>
Date: Wed, 30 Jun 2004 21:33:16 +1000
From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com
Cc: linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC64: (resend) Janitor signature of rtas_call() routine
In-Reply-To: <20040629154202.N21634@forte.austin.ibm.com>
References: <20040629154202.N21634@forte.austin.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 29

Linas,

> Can you please apply the following patch to the ameslab ppc64
> tree, and/or roll it upwards to the marclello 2.6 tree?
> This path is 100% pure cleanup; no functional changes.
> 
> I got irritated when I was given a -1 that was cast to an unsigned
> int that was then cast to a signed (64-bit) long, and so I received
> a value of 4 billion instead of -1.  This patch fixes this insanity.
> 
> Different files were treating this return code as being signed
> or unsigned, 32-bit or 64-bit.  The 'real' return code is always
> a signed 32-bit quantity, so this patch just makes the usage
> consistent across the board.

I beat you to the punch on this one, I'm afraid. :)  I changed
rtas_call to return an int in the prom cleanup patch I sent to Andrew
last week.  You did spot a few places that I missed though, so I'll
send Andrew a patch to fix those up shortly.

Regards,
Paul.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/