Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267401AbUIASJK (ORCPT ); Wed, 1 Sep 2004 14:09:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267359AbUIASJK (ORCPT ); Wed, 1 Sep 2004 14:09:10 -0400 Received: from cantor.suse.de ([195.135.220.2]:19435 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S267400AbUIASHB (ORCPT ); Wed, 1 Sep 2004 14:07:01 -0400 Date: Wed, 01 Sep 2004 20:06:46 +0200 Message-ID: From: Takashi Iwai To: Dave Jones Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove pointless code from ALSA emu10k1 midi driver. In-Reply-To: <200409011551.i81FpMwt000680@delerium.codemonkey.org.uk> References: <200409011551.i81FpMwt000680@delerium.codemonkey.org.uk> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 44 Well it's not ALSA emu10k1 but OSS ;) Takashi At Wed, 1 Sep 2004 16:51:22 +0100, Dave Jones wrote: > > Spotted with the source checker from Coverity.com. > > Signed-off-by: Dave Jones > > > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/sound/oss/emu10k1/midi.c linux-2.6/sound/oss/emu10k1/midi.c > --- bk-linus/sound/oss/emu10k1/midi.c 2004-08-09 13:12:18.000000000 +0100 > +++ linux-2.6/sound/oss/emu10k1/midi.c 2004-08-23 14:08:26.000000000 +0100 > @@ -320,7 +320,6 @@ static ssize_t emu10k1_midi_write(struct > { > struct emu10k1_mididevice *midi_dev = (struct emu10k1_mididevice *) file->private_data; > struct midi_hdr *midihdr; > - ssize_t ret = 0; > unsigned long flags; > > DPD(4, "emu10k1_midi_write(), count=%#x\n", (u32) count); > @@ -344,7 +343,7 @@ static ssize_t emu10k1_midi_write(struct > if (copy_from_user(midihdr->data, buffer, count)) { > kfree(midihdr->data); > kfree(midihdr); > - return ret ? ret : -EFAULT; > + return -EFAULT; > } > > spin_lock_irqsave(&midi_spinlock, flags); > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/