Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267551AbUIAUmv (ORCPT ); Wed, 1 Sep 2004 16:42:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267494AbUIAUmj (ORCPT ); Wed, 1 Sep 2004 16:42:39 -0400 Received: from delerium.kernelslacker.org ([81.187.208.145]:700 "EHLO delerium.codemonkey.org.uk") by vger.kernel.org with ESMTP id S267551AbUIAUmD (ORCPT ); Wed, 1 Sep 2004 16:42:03 -0400 Date: Wed, 1 Sep 2004 21:41:32 +0100 From: Dave Jones To: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix leaks in ISOFS. Message-ID: <20040901204132.GL11182@redhat.com> Mail-Followup-To: Dave Jones , Christoph Hellwig , linux-kernel@vger.kernel.org References: <200409011551.i81FpMUY000655@delerium.codemonkey.org.uk> <20040901180050.A13768@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040901180050.A13768@infradead.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 519 Lines: 16 On Wed, Sep 01, 2004 at 06:00:50PM +0100, Christoph Hellwig wrote: > > MAYBE_CONTINUE(repeat,inode); > > + if (buffer) kfree(buffer); > > kfree(NULL) is just fine True. I got carried away mirroring the style of all the other kfree operations in that code. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/