Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268169AbUIBR7C (ORCPT ); Thu, 2 Sep 2004 13:59:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268065AbUIBR5L (ORCPT ); Thu, 2 Sep 2004 13:57:11 -0400 Received: from web81309.mail.yahoo.com ([206.190.37.84]:27247 "HELO web81309.mail.yahoo.com") by vger.kernel.org with SMTP id S268805AbUIBR4s (ORCPT ); Thu, 2 Sep 2004 13:56:48 -0400 Message-ID: <20040902175647.97709.qmail@web81309.mail.yahoo.com> Date: Thu, 2 Sep 2004 10:56:47 -0700 (PDT) From: Dmitry Torokhov Subject: Re: [PATCH] allow i8042 register location override To: Bjorn Helgaas Cc: Alessandro Rubini , linux-kernel@vger.kernel.org, Andrew Morton , Vojtech Pavlik MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 27 Bjorn Helgass wrote: > Allow the default i8042 register locations to be changed at run-time. > This is a prelude to adding discovery via the ACPI namespace. > > Signed-off-by: Bjorn Helgaas > > > +static unsigned long i8042_command_reg = I8042_COMMAND_REG; > +static unsigned long i8042_status_reg = I8042_STATUS_REG; > +static unsigned long i8042_data_reg = I8042_DATA_REG; > + Hi Bjorn, This will not work as these macros are not constants, see i8042-*io.h and i8042_platform_init(). What you need to do is add ACPI hooks to i8042_platform_init for i386/ia64/etc. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/