Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269411AbUICAQ5 (ORCPT ); Thu, 2 Sep 2004 20:16:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269395AbUICAPI (ORCPT ); Thu, 2 Sep 2004 20:15:08 -0400 Received: from fw.osdl.org ([65.172.181.6]:33511 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S269412AbUICAGQ (ORCPT ); Thu, 2 Sep 2004 20:06:16 -0400 Date: Thu, 2 Sep 2004 17:06:12 -0700 (PDT) From: Linus Torvalds To: Zwane Mwaikambo cc: Linux Kernel , Andrew Morton , Matt Mackall , William Lee Irwin III Subject: Re: [PATCH][1/8] Arch agnostic completely out of line locks / generic In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 24 On Thu, 2 Sep 2004, Zwane Mwaikambo wrote: > + > +#define __lockfunc fastcall __attribute__((section(".spinlock.text"))) > + > +int __lockfunc _spin_trylock(spinlock_t *lock) ... > +int _spin_trylock(spinlock_t *lock); This is horribly horribly wrong. The function is a fastcall function, and it needs to be declared that way, otherwise the callers will use the wrong semantics for calling. This can't have worked. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/