Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269494AbUICBXv (ORCPT ); Thu, 2 Sep 2004 21:23:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269490AbUICBR6 (ORCPT ); Thu, 2 Sep 2004 21:17:58 -0400 Received: from fw.osdl.org ([65.172.181.6]:58261 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S269475AbUICArq (ORCPT ); Thu, 2 Sep 2004 20:47:46 -0400 Date: Thu, 2 Sep 2004 17:47:30 -0700 (PDT) From: Linus Torvalds To: Zwane Mwaikambo cc: Linux Kernel , Andrew Morton , Matt Mackall , William Lee Irwin III Subject: Re: [PATCH][1/8] Arch agnostic completely out of line locks / generic In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 20 On Thu, 2 Sep 2004, Zwane Mwaikambo wrote: > > I'm a moron, unfortunately CONFIG_REGPARM saved my ass :/ The following > works without CONFIG_REGPARM. I really think you should have the __lockfunc define in only one place. If I was a compiler, I'd complain about seeing different section attributes on the definition than on the prototype. Exactly why did you put the __lockfunc only on the definitions, and something else on the declaration? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/