Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269645AbUICMY0 (ORCPT ); Fri, 3 Sep 2004 08:24:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269663AbUICMVS (ORCPT ); Fri, 3 Sep 2004 08:21:18 -0400 Received: from the-village.bc.nu ([81.2.110.252]:27795 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S269645AbUICMRi (ORCPT ); Fri, 3 Sep 2004 08:17:38 -0400 Subject: Re: [PATCH] 2.6.8.1 ES7000 subarch update From: Alan Cox To: Jason Davis Cc: LKML , Andrew Morton In-Reply-To: <20040902235214.GA21954@righTThere.net> References: <20040902235214.GA21954@righTThere.net> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1094210117.7533.28.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Fri, 03 Sep 2004 12:15:21 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 18 On Gwe, 2004-09-03 at 00:52, Jason Davis wrote: > int mip_port; > unsigned long mip_addr, host_addr; > > +EXPORT_SYMBOL(mip_reg); > +EXPORT_SYMBOL(host_reg); > +EXPORT_SYMBOL(mip_port); > +EXPORT_SYMBOL(mip_addr); > +EXPORT_SYMBOL(host_addr); This is asking for collisions with other modules. It would be a lot better for the future it these became e7000_mip_reg etc I think. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/