To: linux-kernel@vger.kernel.org
From: Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [PATCH 2.6] watch64: generic variable monitoring system
Date: Fri, 3 Sep 2004 12:16:57 -0700
Organization: Open Source Development Lab
Message-ID: <20040903121657.355a6a8b@dell_ss3.pdx.osdl.net>
References: <200409031307.01240.jeffpc@optonline.net>
	<200409031319.24863.jeffpc@optonline.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
NNTP-Posting-Date: Fri, 3 Sep 2004 19:16:58 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 993
Lines: 22

On Fri, 03 Sep 2004 13:19:24 -0400
"Josef 'Jeff' Sipek" <jeffpc@optonline.net> wrote:

> The watch64 system allows the programmer to specify the approximate interval
> at which he wants his variables checked. If he tries to specify shorter
> interval than the minimum a default value of HZ/10 is used. To minimize
> locking, RCU and seqlock are used. On 64-bit systems, all is optimized away.
> 
> The following patch can be also pulled from http://jeffpc.bkbits.net/watch64-2.6
> 
> Josef "Jeff" Sipek.
> 
> Signed-off-by: Josef "Jeff" Sipek <jeffpc@optonline.net>

- Seems like a big interface for a simple problem.
- Code doesn't match the kernel style (read Documentation/CodingStyle)
- Does it really need RCU and seqlock, wouldn't one suffice
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/