Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269810AbUICVVL (ORCPT ); Fri, 3 Sep 2004 17:21:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269798AbUICVTP (ORCPT ); Fri, 3 Sep 2004 17:19:15 -0400 Received: from delerium.kernelslacker.org ([81.187.208.145]:44212 "EHLO delerium.codemonkey.org.uk") by vger.kernel.org with ESMTP id S269277AbUICVQI (ORCPT ); Fri, 3 Sep 2004 17:16:08 -0400 Date: Fri, 3 Sep 2004 22:15:47 +0100 From: Dave Jones To: Linux Kernel Cc: Alan Cox Subject: hpt366 ptr use before NULL check. Message-ID: <20040903211546.GY26419@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel , Alan Cox Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 32 Another picked up with the coverity checker. Signed-off-by: Dave Jones --- linux-2.6.8/drivers/ide/pci/hpt366.c~ 2004-09-03 22:13:46.870500672 +0100 +++ linux-2.6.8/drivers/ide/pci/hpt366.c 2004-09-03 22:14:53.095432952 +0100 @@ -773,13 +773,17 @@ static int hpt3xx_tristate (ide_drive_t * drive, int state) { ide_hwif_t *hwif = HWIF(drive); - struct pci_dev *dev = hwif->pci_dev; - u8 reg59h = 0, reset = (hwif->channel) ? 0x80 : 0x40; - u8 regXXh = 0, state_reg= (hwif->channel) ? 0x57 : 0x53; + struct pci_dev *dev; + u8 reg59h = 0, reset; + u8 regXXh = 0, state_reg; if (!hwif) return -EINVAL; + dev = hwif->pci_dev; + reset = (hwif->channel) ? 0x80 : 0x40; + state_reg = (hwif->channel) ? 0x57 : 0x53; + // hwif->bus_state = state; pci_read_config_byte(dev, 0x59, ®59h); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/