Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266619AbUIEMvP (ORCPT ); Sun, 5 Sep 2004 08:51:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266631AbUIEMvP (ORCPT ); Sun, 5 Sep 2004 08:51:15 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:39696 "EHLO mail.parknet.co.jp") by vger.kernel.org with ESMTP id S266619AbUIEMvF (ORCPT ); Sun, 5 Sep 2004 08:51:05 -0400 To: Christoph Hellwig Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] FAT: rewrite the cache for file allocation table lookup (2/4) References: <878ybpvtpz.fsf@devron.myhome.or.jp> <20040905123959.A29612@infradead.org> From: OGAWA Hirofumi Date: Sun, 05 Sep 2004 21:50:38 +0900 In-Reply-To: <20040905123959.A29612@infradead.org> (Christoph Hellwig's message of "Sun, 5 Sep 2004 12:39:59 +0100") Message-ID: <87pt50vq01.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 33 Christoph Hellwig writes: >> +#if 0 >> +#define debug_pr(fmt, args...) printk(fmt, ##args) >> +#else >> +#define debug_pr(fmt, args...) >> +#endif > > We have a pr_debug() in that you could use. I hated KERN_DEBUG. But, well, maybe pr_debug() was enough... I'll replace it for now, and will delete it after public test in Andrew's tree. >> +static inline int fat_max_cache(struct inode *inode) >> +{ >> + return FAT_MAX_CACHE; >> +} > > Do you plan to have per-inode caches later? This seems rather useless > otherwise. This cache is already per-inode. Thanks. -- OGAWA Hirofumi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/