Date: Sun, 5 Sep 2004 11:00:32 -0400
From: Greg KH <greg@kroah.com>
To: John Lenz <lenz@cs.wisc.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Backlight and LCD module patches [2]
Message-ID: <20040905150032.GF12701@kroah.com>
References: <20040617223517.59a56c7e.zap@homelink.ru> <20040725215917.GA7279@hydra.mshome.net> <20040813232739.GB5063@kroah.com> <1093056693l.30570l.0l@hydra>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1093056693l.30570l.0l@hydra>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 29

On Sat, Aug 21, 2004 at 02:51:33AM +0000, John Lenz wrote:
> 
> Here.  A few notes on the implementation.  I have a global lock protecting
> all match operations because otherwise we get a dining philosophers problem.
> (Say the same class is in two class_match structures, class1 in the first 
> one and class2 in the second...)

You also have some duplicated code in one function, which implies that
you didn't test this patch (it's in the updated patch you sent me too) :)

> The bigger question of how should we be linking these together in the first 
> place?

I thought you only wanted the ability to actually find the different
class devices.  Then the code would take it from there.  Not this
complex driver core linking logic that you implemented.

> Instead of using this class_match stuff, we could use class_interface.

Exactly.  Why don't you all use that instead?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/