Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267620AbUIFIcL (ORCPT ); Mon, 6 Sep 2004 04:32:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267624AbUIFIcL (ORCPT ); Mon, 6 Sep 2004 04:32:11 -0400 Received: from fw.osdl.org ([65.172.181.6]:64970 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S267620AbUIFIcH (ORCPT ); Mon, 6 Sep 2004 04:32:07 -0400 Date: Mon, 6 Sep 2004 01:29:39 -0700 From: Andrew Morton To: Kirill Korotaev Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] removes unnessary print of space Message-Id: <20040906012939.65e63521.akpm@osdl.org> In-Reply-To: <413C211D.9010301@sw.ru> References: <413C0CC5.4000807@sw.ru> <20040906000826.73157de6.akpm@osdl.org> <413C211D.9010301@sw.ru> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 21 Kirill Korotaev wrote: > > I've noticed another thing. There is a default bust_spinlocks() in > lib/bust_spinlocks.c. 4 architectures including x86 have their own > copies of it, which are exactly the same as the default one. > > So do we really need lib/bust_spinlocks.c or we can move a signle copy > of this function to kernel/printk.c? I'd leave it as is - nobody's complaining. In the more modern scheme of things we'd move that file to kernel/ and require that per-arch Kconfigs define CONFIG_NEED_GENERIC_BUST_SPINLOCKS, then use that in kernel/Makefile. But doing that now would be gratuitous noise, IMO. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/