Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268225AbUIFQO7 (ORCPT ); Mon, 6 Sep 2004 12:14:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268219AbUIFQO7 (ORCPT ); Mon, 6 Sep 2004 12:14:59 -0400 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:64459 "EHLO dsl.commfireservices.com") by vger.kernel.org with ESMTP id S268225AbUIFQO4 (ORCPT ); Mon, 6 Sep 2004 12:14:56 -0400 Date: Mon, 6 Sep 2004 12:19:24 -0400 (EDT) From: Zwane Mwaikambo To: Andi Kleen Cc: Linux Kernel , Andrew Morton , Linus Torvalds , Matt Mackall , William Lee Irwin III Subject: Re: [PATCH][8/8] Arch agnostic completely out of line locks / x86_64 In-Reply-To: <20040906072859.GB31343@wotan.suse.de> Message-ID: References: <20040904111605.GA12165@wotan.suse.de> <20040906072859.GB31343@wotan.suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 36 Hi Andi, On Mon, 6 Sep 2004, Andi Kleen wrote: > That is with frame pointers enabled. Indeed with frame pointers > on it is not true you still have to special case that. Yes that was with frame pointers enabled, but the following was compiled without frame pointers, i'm still not sure it's safe to use *esp. 00000070 <_spin_lock>: 70: 83 ec 04 sub $0x4,%esp 73: 89 c2 mov %eax,%edx 75: b8 00 e0 ff ff mov $0xffffe000,%eax 7a: 21 e0 and %esp,%eax 7c: ff 40 14 incl 0x14(%eax) 7f: 31 c0 xor %eax,%eax 81: 86 02 xchg %al,(%edx) 83: 84 c0 test %al,%al 85: 7e 02 jle 89 <_spin_lock+0x19> 87: 58 pop %eax 88: c3 ret 89: 89 14 24 mov %edx,(%esp) 8c: e8 fc ff ff ff call 8d <_spin_lock+0x1d> 91: eb f4 jmp 87 <_spin_lock+0x17> 93: 8d b6 00 00 00 00 lea 0x0(%esi),%esi 99: 8d bc 27 00 00 00 00 lea 0x0(%edi),%edi Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/