Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268249AbUIGQHc (ORCPT ); Tue, 7 Sep 2004 12:07:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268284AbUIGPCu (ORCPT ); Tue, 7 Sep 2004 11:02:50 -0400 Received: from fw.osdl.org ([65.172.181.6]:49091 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S268223AbUIGO7S (ORCPT ); Tue, 7 Sep 2004 10:59:18 -0400 Date: Tue, 7 Sep 2004 07:59:11 -0700 (PDT) From: Linus Torvalds To: =?iso-8859-1?Q?J=F6rn?= Engel cc: Andrew Morton , linux-kernel@vger.kernel.org, Steve French Subject: Re: [PATCH 4/4] copyfile: copyfile In-Reply-To: <20040907145118.GA29993@wohnheim.fh-wedel.de> Message-ID: References: <20040907120908.GB26630@wohnheim.fh-wedel.de> <20040907121118.GA27297@wohnheim.fh-wedel.de> <20040907121235.GB27297@wohnheim.fh-wedel.de> <20040907121520.GC27297@wohnheim.fh-wedel.de> <20040907145118.GA29993@wohnheim.fh-wedel.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 25 On Tue, 7 Sep 2004, J?rn Engel wrote: > On Tue, 7 September 2004 07:06:00 -0700, Linus Torvalds wrote: > > > > Then you could (and should) make a "generic_file_copy()" function that > > takes that pathname format, and then uses sendfile() to do the copy for > > regular disk-based filesystems. > > Does that mean that you're ok with the first three patches? No, it means that they weren't fundamentally flawed.. Actually, the 4kB batching one was - if you only max out to using 4kB at a time, sendfile() is kind of pointless, because then it will never do multi-page copies in the first place, and all the complexity at a lower level is worthless.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/