Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268637AbUIGVJ7 (ORCPT ); Tue, 7 Sep 2004 17:09:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268633AbUIGVIR (ORCPT ); Tue, 7 Sep 2004 17:08:17 -0400 Received: from adsl-63-197-226-105.dsl.snfc21.pacbell.net ([63.197.226.105]:8897 "EHLO cheetah.davemloft.net") by vger.kernel.org with ESMTP id S268637AbUIGVFi (ORCPT ); Tue, 7 Sep 2004 17:05:38 -0400 Date: Tue, 7 Sep 2004 14:02:45 -0700 From: "David S. Miller" To: Herbert Xu Cc: util@deuroconsult.ro, netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Trivial fix for out of bounds array access in xfrm4_policy_check Message-Id: <20040907140245.675b7240.davem@davemloft.net> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 22 On Tue, 07 Sep 2004 22:46:22 +1000 Herbert Xu wrote: > Catalinux aka Dino BOIE wrote: > > > > Coverity found a bug in accessing xfrm4_policy_check using XFRM_POLICY_FWD > > (=2) as index in sk->sk_policy. > > > > sk->sk_policy[] is defined in sock.h as: > > > > struct xfrm_policy *sk_policy[2]; > > > > Attached is the fix. > > This is bogus as if the packet is forwarded then sk == NULL. Agreed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/