Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268723AbUIGWxf (ORCPT ); Tue, 7 Sep 2004 18:53:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268724AbUIGWxf (ORCPT ); Tue, 7 Sep 2004 18:53:35 -0400 Received: from imladris.demon.co.uk ([193.237.130.41]:36359 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S268723AbUIGWxe (ORCPT ); Tue, 7 Sep 2004 18:53:34 -0400 Date: Tue, 7 Sep 2004 23:53:27 +0100 From: Christoph Hellwig To: Stephen Tweedie Cc: Andrew Morton , linux-kernel@vger.kernel.org, Mingming Cao , pbadari@us.ibm.com, Ram Pai Subject: Re: [Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls Message-ID: <20040907235327.A21397@infradead.org> Mail-Followup-To: Christoph Hellwig , Stephen Tweedie , Andrew Morton , linux-kernel@vger.kernel.org, Mingming Cao , pbadari@us.ibm.com, Ram Pai References: <200409071302.i87D2ROd030909@sisko.scot.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200409071302.i87D2ROd030909@sisko.scot.redhat.com>; from sct@redhat.com on Tue, Sep 07, 2004 at 02:02:27PM +0100 X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 14 On Tue, Sep 07, 2004 at 02:02:27PM +0100, Stephen Tweedie wrote: > All ext2/3 ioctls apart from these ones use 'f' as the root char for > their macro-generated ioctl numbers; make reservations consistent with > this. Maybe you could reuse the XFS reservation ioctls instead of adding another set? Having incompatible APIs for the same thing on different filesystems sounds like the wrong way to go. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/