Date: Wed, 8 Sep 2004 14:47:51 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [patch] preempt-smp.patch, 2.6.9-rc1-bk14
Message-ID: <20040908124751.GB19231@elte.hu>
References: <20040908111751.GA11507@elte.hu> <20040908124002.A30883@infradead.org> <20040908114446.GA14286@elte.hu> <20040908134152.A31413@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040908134152.A31413@infradead.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 791
Lines: 20


* Christoph Hellwig <hch@infradead.org> wrote:

> > while generic it's actually correct for the purpose it's being used for
> > right now and all architectures should thus compile & work fine.
> 
> Well, if it goes into -mm I'd rather see it not commpile first and let
> arch maintainers do proper version instead of forgetting it.  And
> unless I misread the code it's only used for SMP && PREEMPT anyway,
> right?

right now it's only for SMP && PREEMPT, yes. Both variants are OK to me.
We can add a #warning to the generic define too.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/