Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269109AbUIHORk (ORCPT ); Wed, 8 Sep 2004 10:17:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267615AbUIHOOp (ORCPT ); Wed, 8 Sep 2004 10:14:45 -0400 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:50414 "EHLO dsl.commfireservices.com") by vger.kernel.org with ESMTP id S269140AbUIHONF (ORCPT ); Wed, 8 Sep 2004 10:13:05 -0400 Date: Wed, 8 Sep 2004 10:17:30 -0400 (EDT) From: Zwane Mwaikambo To: "Li, Shaohua" Cc: BlaisorBlade , Linux Kernel Mailing List , acpi-devel@lists.sourceforge.net, "Brown, Len" Subject: RE: [ACPI] Re: [PATCH] Oops and panic while unloading holder of pm_idle In-Reply-To: <16A54BF5D6E14E4D916CE26C9AD30575120967@pdsmsx402.ccr.corp.intel.com> Message-ID: References: <16A54BF5D6E14E4D916CE26C9AD30575120967@pdsmsx402.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 25 Hello Shaohua, On Wed, 8 Sep 2004, Li, Shaohua wrote: > Yes, preempt will cause oops in pc_idle. Attached patch should close the > final race corner. Please try and inline your patches in future, i know it may be hard with your mail client but it makes commenting on patches easier. while (!need_resched()) { + void (*idle)(void) = NULL; + You don't need to initialise variable `idle` here. Otherwise the rest looks fine with me. Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/