Subject: Re: [PATCH] missing pci_disable_device()
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: greg@kroah.com, akpm@osdl.org, bjorn.helgaas@hp.com,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <413E7925.1010801@jp.fujitsu.com>
References: <413D0E4E.1000200@jp.fujitsu.com>
	 <1094550581.9150.8.camel@localhost.localdomain>
	 <413E7925.1010801@jp.fujitsu.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1094647195.11723.5.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Wed, 08 Sep 2004 13:39:56 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1065
Lines: 22

On Mer, 2004-09-08 at 04:14, Kenji Kaneshige wrote:
> > Think about unloading frame buffers or PCI devices with multiple
> > functions and multiple drivers. I agree the drivers definitely want
> > fixing where appropriate. I'm not sure your approach is safe (although a
> 
> I don't understand what you are worried about. Could you tell me
> what would be a problem with frame buffers or PCI devices with
> multiple functions?

If I have a framebuffer driver loaded for my video card in bitmap mode
all is well. If I unload it you then disable the video hardware even
though it would still be otherwise usable in text mode.

The same occurs when one PCI device has multiple functions (not PCI
functions but linux drivers using it). There are some examples of this
such as the CS5520 where one BAR is the IDE controller.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/