Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269281AbUIIBJe (ORCPT ); Wed, 8 Sep 2004 21:09:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269319AbUIIBJd (ORCPT ); Wed, 8 Sep 2004 21:09:33 -0400 Received: from dragnfire.mtl.istop.com ([66.11.160.179]:15306 "EHLO dsl.commfireservices.com") by vger.kernel.org with ESMTP id S269281AbUIIBJa (ORCPT ); Wed, 8 Sep 2004 21:09:30 -0400 Date: Wed, 8 Sep 2004 21:14:00 -0400 (EDT) From: Zwane Mwaikambo To: "Li, Shaohua" Cc: BlaisorBlade , acpi-devel@lists.sourceforge.net, Linux Kernel Mailing List , "Brown, Len" Subject: RE: [ACPI] Re: [PATCH] Oops and panic while unloading holder of pm_idle In-Reply-To: <16A54BF5D6E14E4D916CE26C9AD305751210A8@pdsmsx402.ccr.corp.intel.com> Message-ID: References: <16A54BF5D6E14E4D916CE26C9AD305751210A8@pdsmsx402.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 29 Hello Shaohua, > + /* Wait the idle thread to read the new value, > + * otherwise we Oops. > + */ I should have mentioned this earlier, but the comment needs work, something like this; "We are about to unload the current idle thread pm callback (pm_idle), Wait for all processors to update cached/local copies of pm_idle before proceeding." > + /* If pm_idle is in a module and is preempted, > + * oops occurs. Disable preempt. > + */ "Mark this as an RCU critical section so that synchronize_kernel() in the unload path waits for our completion." Then resend the patch, i swear it'll be the last time ;) Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/