Subject: Re: [PATCH] missing pci_disable_device()
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Greg KH <greg@kroah.com>, akpm@osdl.org, bjorn.helgaas@hp.com,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <41403075.1010103@jp.fujitsu.com>
References: <413D0E4E.1000200@jp.fujitsu.com>
	 <1094550581.9150.8.camel@localhost.localdomain>
	 <413E7925.1010801@jp.fujitsu.com>
	 <1094647195.11723.5.camel@localhost.localdomain>
	 <413FF05B.8090505@jp.fujitsu.com> <20040909062009.GD10428@kroah.com>
	 <41403075.1010103@jp.fujitsu.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1094735472.14640.18.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Thu, 09 Sep 2004 14:11:13 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 28

On Iau, 2004-09-09 at 11:29, Kenji Kaneshige wrote:
> > 	dev_warn(&pci_dev->dev, "Device was removed without properly "
> > 				"calling pci_disable_device(), please fix.\n");
> > 	WARN_ON(1);
> > 

"This may need fixing" would be better than "please fix" as it may be
a wrong warning

> I changed my patch based on your feedback. But I have one
> concern about putting "WARN_ON(1);". I'm worrying that people
> might be surprised if stack dump is shown on their console,
> especially if the broken driver handles many devices.

You could put

#ifdef CONFIG_DEBUG_KERNEL

#endif

around that section, then only users selecting kernel debugging would
be bothered by it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/