Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266351AbUIIRVm (ORCPT ); Thu, 9 Sep 2004 13:21:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266366AbUIIRVW (ORCPT ); Thu, 9 Sep 2004 13:21:22 -0400 Received: from holomorphy.com ([207.189.100.168]:43441 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S266362AbUIIRUJ (ORCPT ); Thu, 9 Sep 2004 13:20:09 -0400 Date: Thu, 9 Sep 2004 10:19:27 -0700 From: William Lee Irwin III To: Linus Torvalds Cc: Kirill Korotaev , akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] adding per sb inode list to make invalidate_inodes() faster Message-ID: <20040909171927.GU3106@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Linus Torvalds , Kirill Korotaev , akpm@osdl.org, linux-kernel@vger.kernel.org References: <4140791F.8050207@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 27 On Thu, Sep 09, 2004 at 08:51:45AM -0700, Linus Torvalds wrote: > Hmm.. I don't mind the approach per se, but I get very nervous about the > fact that I don't see any initialization of "inode->i_sb_list". > Yes, you do a > list_add(&inode->i_sb_list, &sb->s_inodes); > in new_inode(), but there are a ton of users that allocate inodes other > ways, and more importantly, even if this was the only allocation function, > you do various "list_del(&inode->i_sb_list)" things which leaves the inode > around but with an invalid superblock list. > So at the very _least_, you should document why all of this is safe very > carefully (I get nervous about fundamental FS infrastructure changes), and > it should be left to simmer in -mm for a longish time to make sure it > really works.. > Call me chicken. Some version of this patch has been in 2.6.x-mm for a long while. I've not reviewed this version of the patch for differences with the -mm code. It would probably be best to look at the -mm bits as they've had sustained exposure for quite some time. -- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/