Date: Thu, 9 Sep 2004 21:11:42 +0200
From: Roger Luethi <rl@hellgate.ch>
To: William Lee Irwin III <wli@holomorphy.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, Albert Cahalan <albert@users.sf.net>,
       Paul Jackson <pj@sgi.com>
Subject: Re: [1/1][PATCH] nproc v2: netlink access to /proc information
Message-ID: <20040909191142.GA30151@k3.hellgate.ch>
Mail-Followup-To: William Lee Irwin III <wli@holomorphy.com>,
	Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
	Albert Cahalan <albert@users.sf.net>, Paul Jackson <pj@sgi.com>
References: <20040908184028.GA10840@k3.hellgate.ch> <20040908184130.GA12691@k3.hellgate.ch> <20040909003529.GI3106@holomorphy.com> <20040909184300.GA28278@k3.hellgate.ch> <20040909184933.GG3106@holomorphy.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040909184933.GG3106@holomorphy.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 30

On Thu, 09 Sep 2004 11:49:33 -0700, William Lee Irwin III wrote:
> I'll follow up shortly with a task_mem()/task_mem_cheap() consolidation
> patch atop the others I sent.

I have a few minor changes coming up as well.

One nitpick: As vmexe and vmlib are always 0 for !CONFIG_MMU, we should
ifdef them out of the list of offered fields for that configuration (and
maybe in nproc_ps_field as well).

> On Thu, Sep 09, 2004 at 08:43:01PM +0200, Roger Luethi wrote:
> > There seems to be a discrepancy between current task_mem in
> > fs/proc/task_nommu.c and the __task_mem{,_cheap} routines you wrote
> > for the nproc !CONFIG_MMU case. Can you explain?
> 
> I'm not aware of a discrepancy with the fs/proc/task_nommu.c code; I
> did, however, have to mangle the things via guesswork to avoid adding
> the new fields, which I really wanted you to arrange for or comment on
> as they are a matter of interface. Also, could you be more specific
> about these discrepancies?

task_nommu.c offers Mem, Slack, and Shared. __task_mem for !CONFIG_MMU
offers VmData, VmStack, VmRSS, VmSize.

Roger
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/